Merged
Conversation
Contributor
Author
|
@TomasVotruba Hello, can you review this PR please |
|
@TomasVotruba please we need this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new execOrDie function to handle command execution failures more consistently by automatically terminating the script when any exec command fails. The change addresses issue #17 by replacing direct exec calls with execOrDie throughout the codebase.
- Adds
execOrDiefunction that checks exit codes and terminates on failure - Replaces all
execcalls withexecOrDiefor consistent error handling - Removes manual exit code checking logic that is now handled by the new function
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Hallelujah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if any exec fails - job fails too.
Fixed #17